fix: Make ExtensionRunner#closeBrowser optional (#2092)

Co-authored-by: Patryk Kuniczak <p.kuniczak@gmail.com>
This commit is contained in:
Aaron
2026-02-09 01:44:35 -06:00
committed by GitHub
parent f84921f735
commit 07a4ba8bc5
5 changed files with 5 additions and 12 deletions
+2 -2
View File
@@ -126,7 +126,7 @@ async function createServerInternal(): Promise<WxtDevServer> {
async stop() {
wasStopped = true;
keyboardShortcuts.stop();
await runner.closeBrowser();
await runner.closeBrowser?.();
await builderServer.close();
await wxt.hooks.callHook('server:closed', wxt, server);
@@ -150,7 +150,7 @@ async function createServerInternal(): Promise<WxtDevServer> {
server.ws.send('wxt:reload-extension');
},
async restartBrowser() {
await runner.closeBrowser();
await runner.closeBrowser?.();
keyboardShortcuts.stop();
await wxt.reloadConfig();
runner = await createExtensionRunner();
-3
View File
@@ -15,8 +15,5 @@ export function createManualRunner(): ExtensionRunner {
)}" as an unpacked extension manually`,
);
},
async closeBrowser() {
// noop
},
};
}
-3
View File
@@ -15,8 +15,5 @@ export function createSafariRunner(): ExtensionRunner {
)}" as an unpacked extension manually`,
);
},
async closeBrowser() {
// noop
},
};
}
-3
View File
@@ -15,8 +15,5 @@ export function createWslRunner(): ExtensionRunner {
)}" as an unpacked extension manually`,
);
},
async closeBrowser() {
// noop
},
};
}
+3 -1
View File
@@ -1428,7 +1428,9 @@ export interface FsCache {
export interface ExtensionRunner {
openBrowser(): Promise<void>;
closeBrowser(): Promise<void>;
closeBrowser?(): Promise<void>;
/** Whether or not this runner actually opens the browser. */
canOpen?(): boolean;
}