From 50bb8454ddb4d57f1b2dbf332e536ffa2cecc732 Mon Sep 17 00:00:00 2001
From: Aaron Klinker <aklinker1@users.noreply.github.com>
Date: Sun, 25 Jun 2023 20:53:32 -0500
Subject: [PATCH] fix: Firefox manifest warnings in dev mode

---
 src/utils/manifest.ts | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/utils/manifest.ts b/src/utils/manifest.ts
index ef2af805..cb1680e6 100644
--- a/src/utils/manifest.ts
+++ b/src/utils/manifest.ts
@@ -58,7 +58,7 @@ export async function generateMainfest(
     name: pkg.name,
     short_name: pkg.shortName,
     version: simplifyVersion(pkg.version),
-    version_name: pkg.version,
+    version_name: config.browser === 'firefox' ? undefined : pkg.version,
     ...config.manifest,
   };
 
@@ -271,13 +271,15 @@ function addEntrypoints(
 
   if (contentScripts?.length) {
     if (config.command === 'serve') {
-      const hostPermissions = new Set<string>(manifest.host_permissions ?? []);
+      const permissionsKey =
+        config.manifestVersion === 2 ? 'permissions' : 'host_permissions';
+      const hostPermissions = new Set<string>(manifest[permissionsKey] ?? []);
       contentScripts.forEach((script) => {
         script.options.matches.forEach((matchPattern) => {
           hostPermissions.add(matchPattern);
         });
       });
-      manifest.host_permissions = Array.from(hostPermissions).sort();
+      manifest[permissionsKey] = Array.from(hostPermissions).sort();
     } else {
       const hashToEntrypointsMap = contentScripts.reduce((map, script) => {
         const hash = JSON.stringify(script.options);