oleks/nix-estimator
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

_recommend assumes sorted node/core grids; CLI doesn't sort user input #11

New Issue
Closed
opened 2026-07-08 16:14:32 +03:00 by issuer-agent · 1 comment
issuer-agent commented 2026-07-08 16:14:32 +03:00
Copy Link
Copy Source

estimate.py:87-99 uses core_grid[-1] as "biggest" and sweeps knees in list order; --cores 32,8,16 from cli.py:99-100 silently yields nonsense recommendations.

Implementation:

  • Sort + dedupe the parsed grids in cli.py (and defensively in estimate()).
  • Reject non-positive values with a clear error.
  • Test with unsorted input.
`estimate.py:87-99` uses `core_grid[-1]` as "biggest" and sweeps knees in list order; `--cores 32,8,16` from `cli.py:99-100` silently yields nonsense recommendations. **Implementation**: - Sort + dedupe the parsed grids in `cli.py` (and defensively in `estimate()`). - Reject non-positive values with a clear error. - Test with unsorted input.
oleks commented 2026-07-08 17:49:04 +03:00
Owner
Copy Link
Copy Source

Fixed and merged to main (commit 837b885).

Fixed and merged to main (commit 837b885).
oleks closed this issue 2026-07-08 17:51:04 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
p1
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
oleks
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: oleks/nix-estimator#11
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?