oleks
c19ecab35d
Closing or reopening an issue did not notify project boards that carry it as a card, so board tabs showed stale state until a manual reload. CloseIssue/ReopenIssue only published milestone events and the issue timeline notification — nothing project-scoped. Add a CardStateChanged project event, published per linked project from CloseIssue/ReopenIssue (best-effort; never fails the state change). The board frontend flips the issue-state octicon in place and refetches the affected column so state-filtered boards and counts stay correct. The dispatch check precedes the CardUnlinked branch so a close/reopen is not mistaken for a card removal. Also switch a pre-existing String#match to RegExp#exec in the same file to keep it lint-clean. Closes #19
84 lines
2.6 KiB
Go
84 lines
2.6 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package issue
|
|
|
|
import (
|
|
"context"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/log"
|
|
milestone_events "code.gitea.io/gitea/services/milestone_events"
|
|
notify_service "code.gitea.io/gitea/services/notify"
|
|
project_events "code.gitea.io/gitea/services/project_events"
|
|
)
|
|
|
|
// publishProjectCardStateChanged notifies every project board the issue is a
|
|
// card on that its open/closed state changed, so subscribed board tabs can
|
|
// re-render the card live instead of showing stale state until reload.
|
|
// Best-effort: a failure here must not fail the close/reopen operation.
|
|
func publishProjectCardStateChanged(ctx context.Context, issue *issues_model.Issue, isClosed bool) {
|
|
if err := issue.LoadProjects(ctx); err != nil {
|
|
log.Error("LoadProjects for issue[%d]: %v", issue.ID, err)
|
|
return
|
|
}
|
|
for _, p := range issue.Projects {
|
|
project_events.PublishCardStateChanged(ctx, project_events.CardStateChanged{
|
|
ProjectID: p.ID,
|
|
IssueID: issue.ID,
|
|
IsClosed: isClosed,
|
|
})
|
|
}
|
|
}
|
|
|
|
// CloseIssue close an issue.
|
|
func CloseIssue(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, commitID string) error {
|
|
var comment *issues_model.Comment
|
|
if err := db.WithTx(ctx, func(ctx context.Context) error {
|
|
var err error
|
|
comment, err = issues_model.CloseIssue(ctx, issue, doer)
|
|
if err != nil {
|
|
if issues_model.IsErrDependenciesLeft(err) {
|
|
if _, err := issues_model.FinishIssueStopwatch(ctx, doer, issue); err != nil {
|
|
log.Error("Unable to stop stopwatch for issue[%d]#%d: %v", issue.ID, issue.Index, err)
|
|
}
|
|
}
|
|
return err
|
|
}
|
|
|
|
_, err = issues_model.FinishIssueStopwatch(ctx, doer, issue)
|
|
return err
|
|
}); err != nil {
|
|
return err
|
|
}
|
|
|
|
if issue.MilestoneID > 0 {
|
|
milestone_events.PublishMilestoneProgress(ctx, issue.MilestoneID)
|
|
}
|
|
|
|
notify_service.IssueChangeStatus(ctx, doer, commitID, issue, comment, true)
|
|
publishProjectCardStateChanged(ctx, issue, true)
|
|
|
|
return nil
|
|
}
|
|
|
|
// ReopenIssue reopen an issue.
|
|
// FIXME: If some issues dependent this one are closed, should we also reopen them?
|
|
func ReopenIssue(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, commitID string) error {
|
|
comment, err := issues_model.ReopenIssue(ctx, issue, doer)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if issue.MilestoneID > 0 {
|
|
milestone_events.PublishMilestoneProgress(ctx, issue.MilestoneID)
|
|
}
|
|
|
|
notify_service.IssueChangeStatus(ctx, doer, commitID, issue, comment, false)
|
|
publishProjectCardStateChanged(ctx, issue, false)
|
|
|
|
return nil
|
|
}
|